Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

doesn't compile on 3.1.0vanilla #52

Closed
Rudd-O opened this issue Oct 28, 2011 · 2 comments
Closed

doesn't compile on 3.1.0vanilla #52

Rudd-O opened this issue Oct 28, 2011 · 2 comments

Comments

@Rudd-O
Copy link

Rudd-O commented Oct 28, 2011

make -C /home/rudd-o/Projects/Third-party/linux/karen.dragonfear SUBDIRS=pwd modules
make[3]: Entering directory `/home/rudd-o/Projects/Third-party/linux/karen.dragonfear'
CC [M] /home/rudd-o/Projects/Third-party/spl/module/spl/../../module/spl/spl-debug.o
CC [M] /home/rudd-o/Projects/Third-party/spl/module/spl/../../module/spl/spl-proc.o
CC [M] /home/rudd-o/Projects/Third-party/spl/module/splat/../../module/splat/splat-ctl.o
/home/rudd-o/Projects/Third-party/spl/module/spl/../../module/spl/spl-debug.c: In function ‘spl_debug_dump_all_pages’:
/home/rudd-o/Projects/Third-party/spl/module/spl/../../module/spl/spl-debug.c:963:9: error: too few arguments to function ‘filp->f_op->fsync’
make[5]: *** [/home/rudd-o/Projects/Third-party/spl/module/spl/../../module/spl/spl-debug.o] Error 1
make[5]: *** Waiting for unfinished jobs....

woops.

@behlendorf
Copy link
Contributor

Now that 3.1's out and the interfaces have stabilized we'll get support for it in to the next release candidate.

behlendorf added a commit that referenced this issue Nov 10, 2011
Prior to Linux 3.1 the kern_path_parent symbol was exported for
use by kernel modules.  As of Linux 3.1 it is now longer easily
available.  To handle this case the spl will now dynamically
look up address of the missing symbol at module load time.

Signed-off-by: Brian Behlendorf <[email protected]>
Issue #52
behlendorf added a commit that referenced this issue Nov 10, 2011
Preferentially use the vfs_fsync() function.  This function was
initially introduced in 2.6.29 and took three arguments.  As
of 2.6.35 the dentry argument was dropped from the function.
For older kernels fall back to using file_fsync() which also
took three arguments including the dentry.

Signed-off-by: Brian Behlendorf <[email protected]>
Issue #52
behlendorf added a commit that referenced this issue Nov 10, 2011
As of Linux 3.1 the shrink_dcache_memory and shrink_icache_memory
functions have been removed.  This same task is now accomplished
more cleanly with per super block shrinkers.  This unfortunately
leaves us no easy way to support the dnlc_reduce_cache() function.

This support has always been entirely optional.  So when no
reasonable interface is available allow the dnlc_reduce_cache()
function to effectively become a no-op.

The downside of this change is that it will prevent the zfs arc
meta data limts from being enforced.  However, the current zfs
implementation in this regard is already flawed and needs to
be reworked.  If the arc needs to enfore a meta data limit it
will need to be extended to coordinate directly with the zpl.
This will allow us to drop all this compatibility code and get
more fine grained control over the cache management.

Signed-off-by: Brian Behlendorf <[email protected]>
Issue #52
@behlendorf
Copy link
Contributor

Closing issue, the required compatibility code has been merged in to master. Please open a new issue if you observe any issues, the changes have been tested under fedora 16 which using a 3.1 based kernel.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants