Mainline 3.11 (2013-09-02) compile issues (get_vmalloc_info_fn)

[abyxcos]

spl-0.6.2 is failing to build on mainline 3.11 (2013-09-02) complaining about get_vmalloc_info_fn. This patch fixes it, but I'm not sure it's the right thing. Probably needs some proper automagic around that function. Compile logs are below.

bash-4.2# cat kernel-3.11.local.patch
--- include/sys/vmsystm.h       2013-09-14 15:55:50.594476136 +0000
+++ include/sys/vmsystm.h.new   2013-09-14 15:53:51.499485852 +0000
@@ -82,7 +82,7 @@
 #endif

 typedef void (*get_vmalloc_info_t)(struct vmalloc_info *);
-extern get_vmalloc_info_t get_vmalloc_info_fn;
+//extern get_vmalloc_info_t get_vmalloc_info_fn;

 # define VMEM_ALLOC            0x01
 # define VMEM_FREE             0x02

./configure --prefix=/usr --mandir=/usr/man --with-linux=/usr/src/linux
checking for gawk... gawk
checking metadata... META file
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking target system type... x86_64-unknown-linux-gnu
checking whether to enable maintainer-specific portions of Makefiles... no
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking whether make sets $(MAKE)... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking for style of include used by make... GNU
checking dependency style of gcc... gcc3
checking for a sed that does not truncate output... /bin/sed
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for ar... ar
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking spl license... GPL
checking linux distribution... 
checking default package type... rpm
checking whether rpm is available... no
checking whether rpmbuild is available... no
checking whether spec files are available... yes (rpm/generic/*.spec.in)
checking whether dpkg is available... no
checking whether dpkg-buildpackage is available... no
checking whether alien is available... no
checking spl config... all
checking kernel source directory... /usr/src/linux
checking kernel build directory... /usr/src/linux
checking kernel source version... 3.11.0-1
checking kernel file name for module symbols... Module.symvers
checking whether debugging is enabled... no
checking whether basic debug logging is enabled... yes
checking whether basic kmem accounting is enabled... yes
checking whether detailed kmem tracking is enabled... no
checking whether modules can be built... yes
checking whether atomic types use spinlocks... no
checking whether kernel defines atomic64_t... yes
checking whether kernel defines atomic64_cmpxchg... yes
checking whether kernel defines atomic64_xchg... yes
checking whether kernel defines uintptr_t... yes
checking whether register_sysctl_table() wants 2 args... no
checking whether set_shrinker() available... no
checking whether shrinker callback wants 3 args... no
checking whether struct path used in struct nameidata... yes
checking whether task_curr() is available... no
checking whether unnumbered sysctl support exists... no
checking whether struct ctl_table has ctl_name... no
checking whether struct vmalloc_info is declared... yes
checking whether PDE_DATA() is available... yes
checking whether fls64() is available... yes
checking whether device_create() is available... yes
checking whether device_create() wants 5 args... yes
checking whether class_device_create() is available... no
checking whether set_normalized_timespec() is available as export... yes
checking whether set_normalized_timespec() is an inline... yes
checking whether timespec_sub() is available... yes
checking whether init_utsname() is available... yes
checking whether header linux/uaccess.h exists... yes
checking whether kmalloc_node() is available... yes
checking whether monotonic_clock() is available... no
checking whether struct inode has i_mutex... yes
checking whether struct mutex has owner... no
checking whether struct mutex owner is a task_struct... no
checking whether mutex_lock_nested() is available... yes
checking whether on_each_cpu() wants 3 args... yes
checking whether kallsyms_lookup_name() is available... yes
checking whether get_vmalloc_info() is available... no
checking whether symbol *_pgdat exist... yes
checking whether first_online_pgdat() is available... no
checking whether next_online_pgdat() is available... no
checking whether next_zone() is available... no
checking whether pgdat_list is available... no
checking whether global_page_state() is available... yes
checking whether page state NR_FREE_PAGES is available... yes
checking whether page state NR_INACTIVE is available... no
checking whether page state NR_INACTIVE_ANON is available... yes
checking whether page state NR_INACTIVE_FILE is available... yes
checking whether page state NR_ACTIVE is available... no
checking whether page state NR_ACTIVE_ANON is available... yes
checking whether page state NR_ACTIVE_FILE is available... yes
checking whether symbol get_zone_counts is needed... no
checking whether user_path_dir() is available... yes
checking whether set_fs_pwd() is available... no
checking whether set_fs_pwd() requires const struct path *... yes
checking whether vfs_unlink() wants 2 args... yes
checking whether vfs_rename() wants 4 args... yes
checking whether vfs_fsync() is available... yes
checking whether vfs_fsync() wants 2 args... yes
checking whether truncate_range() inode operation is available... no
checking whether struct fs_struct uses spinlock_t... yes
checking whether struct cred exists... yes
checking whether kuid_t/kgid_t is available... yes; optional
checking whether groups_search() is available... no
checking whether __put_task_struct() is available... yes
checking whether proc_handler() wants 5 args... yes
checking whether kvasprintf() is available... yes
checking whether rwsem_is_locked() acquires sem->wait_lock... no
checking whether fops->fallocate() exists... yes
checking whether iops->fallocate() exists... no
checking whether fops->fallocate() exists... no
checking whether shrink_dcache_memory() is available... no
checking whether shrink_icache_memory() is available... no
checking whether symbol kern_path_parent exists in header... no
checking whether kern_path_parent() is available... no
checking whether symbol kern_path_locked exists in header... yes
checking whether CONFIG_KALLSYMS is defined... yes
checking whether CONFIG_ZLIB_INFLATE is defined... yes
checking whether CONFIG_ZLIB_DEFLATE is defined... yes
checking whether zlib_deflate_workspacesize() wants 2 args... yes
checking whether struct shrink_control exists... yes
checking whether struct rw_semaphore member wait_lock is raw... yes
checking whether header linux/sched/rt.h exists... yes
checking whether vfs_getattr() wants... 2 args
configure: creating ./config.status
config.status: creating Makefile
config.status: creating man/Makefile
config.status: creating man/man1/Makefile
config.status: creating lib/Makefile
config.status: creating cmd/Makefile
config.status: creating module/Makefile
config.status: creating module/spl/Makefile
config.status: creating module/splat/Makefile
config.status: creating include/Makefile
config.status: creating include/fs/Makefile
config.status: creating include/linux/Makefile
config.status: creating include/rpc/Makefile
config.status: creating include/sharefs/Makefile
config.status: creating include/sys/Makefile
config.status: creating include/sys/fm/Makefile
config.status: creating include/sys/fs/Makefile
config.status: creating include/sys/sysevent/Makefile
config.status: creating include/util/Makefile
config.status: creating include/vm/Makefile
config.status: creating scripts/Makefile
config.status: creating rpm/Makefile
config.status: creating rpm/fedora/Makefile
config.status: creating rpm/fedora/spl.spec
config.status: creating rpm/fedora/spl-kmod.spec
config.status: creating rpm/fedora/spl-dkms.spec
config.status: creating rpm/generic/Makefile
config.status: creating rpm/generic/spl.spec
config.status: creating rpm/generic/spl-kmod.spec
config.status: creating rpm/generic/spl-dkms.spec
config.status: creating spl.release
config.status: creating spl_config.h
config.status: executing depfiles commands
config.status: executing libtool commands

make
make  all-recursive
make[1]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2'
Making all in include
make[2]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include'
Making all in fs
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include/fs'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include/fs'
Making all in linux
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include/linux'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include/linux'
Making all in rpc
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include/rpc'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include/rpc'
Making all in sharefs
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include/sharefs'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include/sharefs'
Making all in sys
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include/sys'
Making all in fm
make[4]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include/sys/fm'
make[4]: Nothing to be done for `all'.
make[4]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include/sys/fm'
Making all in fs
make[4]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include/sys/fs'
make[4]: Nothing to be done for `all'.
make[4]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include/sys/fs'
Making all in sysevent
make[4]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include/sys/sysevent'
make[4]: Nothing to be done for `all'.
make[4]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include/sys/sysevent'
make[4]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include/sys'
make[4]: Nothing to be done for `all-am'.
make[4]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include/sys'
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include/sys'
Making all in util
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include/util'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include/util'
Making all in vm
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include/vm'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include/vm'
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/include'
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include'
make[2]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/include'
Making all in rpm
make[2]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/rpm'
Making all in fedora
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/rpm/fedora'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/rpm/fedora'
Making all in generic
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/rpm/generic'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/rpm/generic'
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/rpm'
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/rpm'
make[2]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/rpm'
Making all in lib
make[2]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/lib'
  CC     list.lo
  CCLD   libcommon.la
make[2]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/lib'
Making all in cmd
make[2]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/cmd'
  CC     spl.o
  CC     splat.o
  CCLD   spl
  CCLD   splat
make[2]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/cmd'
Making all in man
make[2]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/man'
Making all in man1
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/man/man1'
make[3]: Nothing to be done for `all'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/man/man1'
make[3]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/man'
make[3]: Nothing to be done for `all-am'.
make[3]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/man'
make[2]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/man'
Making all in scripts
make[2]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/scripts'
make[2]: Nothing to be done for `all'.
make[2]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/scripts'
Making all in module
make[2]: Entering directory `/usr/ports/work/spl/src/spl-0.6.2/module'
make -C /usr/src/linux SUBDIRS=`pwd`  CONFIG_SPL=m modules
make[3]: Entering directory `/usr/src/linux-3.11'
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-debug.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-ctl.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-kmem.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-proc.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-kmem.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-thread.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-taskq.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-rwlock.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-taskq.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-vnode.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-random.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-mutex.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-condvar.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-err.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-time.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-thread.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-rwlock.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-kobj.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-generic.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-atomic.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-time.o
In file included from /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-generic.c:29:0:
/usr/ports/work/spl/src/spl-0.6.2/include/sys/vmsystm.h:84:43: warning: 'struct vmalloc_info' declared inside parameter list [enabled by default]
/usr/ports/work/spl/src/spl-0.6.2/include/sys/vmsystm.h:84:43: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
In file included from /usr/ports/work/spl/src/spl-0.6.2/include/sys/kmem.h:30:0,
                 from /usr/ports/work/spl/src/spl-0.6.2/include/sys/vnode.h:38,
                 from /usr/ports/work/spl/src/spl-0.6.2/include/sys/kobj.h:28,
                 from /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-generic.c:30:
include/linux/vmalloc.h:184:13: error: 'get_vmalloc_info_fn' redeclared as different kind of symbol
In file included from /usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-generic.c:29:0:
/usr/ports/work/spl/src/spl-0.6.2/include/sys/vmsystm.h:85:27: note: previous declaration of 'get_vmalloc_info_fn' was here
make[5]: *** [/usr/ports/work/spl/src/spl-0.6.2/module/spl/../../module/spl/spl-generic.o] Error 1
make[5]: *** Waiting for unfinished jobs....
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-vnode.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-kobj.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-atomic.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-list.o
make[4]: *** [/usr/ports/work/spl/src/spl-0.6.2/module/spl] Error 2
make[4]: *** Waiting for unfinished jobs....
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-generic.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-zlib.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-cred.o
  CC [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/../../module/splat/splat-linux.o
  LD [M]  /usr/ports/work/spl/src/spl-0.6.2/module/splat/splat.o
make[3]: *** [_module_/usr/ports/work/spl/src/spl-0.6.2/module] Error 2
make[3]: Leaving directory `/usr/src/linux-3.11'
make[2]: *** [modules] Error 2
make[2]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2/module'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/ports/work/spl/src/spl-0.6.2'
make: *** [all] Error 2

[maci0]

same error here on archlinux (raspberry pi)

[ryao]

@abyxcos I have opened #297 with a fix.

@maci0 I do not recommend using ZFSOnLinux on the Raspberry Pi until openzfs/zfs#75 is resolved. Until then, ZFS will hang on the Raspberry Pi whenever the Linux kernel runs out of 32-bit kernel virtual address space due to a design decision made in Linux.

[maci0]

@ryao wouldn't disabling the ARC cache work for the rpi ? the thing has 256MB of RAM. I don't expect great performance anyway.

[ryao]

@maci0 No.

On another note, it seems that I built the wrong branch when testing this, which caused me to miss the fact that I made a mistake here. I just pushed a revised commit to #297 that fixes that.