Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Enhancement] Add gci linter check #694

Merged
merged 1 commit into from
Dec 24, 2021
Merged

Conversation

Congrool
Copy link
Member

@Congrool Congrool commented Dec 23, 2021

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

After intergating gci linter into CI workflow, we can check the import package format automatically, including

  1. repeated import
  2. wrong 3-rd part package import order
  3. no empty line before import with comment

More import format to be checked by gci linter can be seen in the README of gci repo.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

other Note

It's recommanded that developer should always run make lint at local host before submitting a pr.
Developers can run make lint at local host to get more info about lint error if any. There're more details than what github action outputs, including the file name and line number which cause this error.

@openyurt-bot
Copy link
Collaborator

@Congrool: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

After intergating gci linter into CI workflow, we can check the import package format automatically, including

  1. repeated import
  2. wrong 3-rd part package import order
  3. no empty line before import with comment
    More import format to be check by gci linter can be seen in the README of gci repo.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

other Note

It's recommanded that developer should always run make lint at local host before submitting a pr.
Developers can run make lint at local host to get more info about lint error if any. There're more details than what github action outputs, including the file name and line number which cause this error.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rambohe-ch
Copy link
Member

@Congrool Very appreciate for your job. It is very helpful to add gci linter checker for OpenYurt.

@openyurt-bot openyurt-bot added the approved approved label Dec 24, 2021
@rambohe-ch
Copy link
Member

/lgtm
/approve

@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rambohe-ch rambohe-ch merged commit 402dc8c into openyurtio:master Dec 24, 2021
@Congrool Congrool deleted the lint branch December 24, 2021 14:15
MrGirl pushed a commit to MrGirl/openyurt that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/enhancement kind/enhancement lgtm lgtm size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants