-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI Enhancement] Add gci linter check #694
Conversation
@Congrool: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Congrool Very appreciate for your job. It is very helpful to add gci linter checker for OpenYurt. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Congrool, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind enhancement
What this PR does / why we need it:
After intergating gci linter into CI workflow, we can check the import package format automatically, including
More import format to be checked by gci linter can be seen in the README of gci repo.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
other Note
It's recommanded that developer should always run
make lint
at local host before submitting a pr.Developers can run
make lint
at local host to get more info about lint error if any. There're more details than what github action outputs, including the file name and line number which cause this error.