Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(yurtctl): ensure the join token of yurthub has right usages and groups #510

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

DrmagicE
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind bug

What this PR does / why we need it:

When converting cluster with yurtctl convert, yurtctl will try to get the join-token for yurthub from Kubernetes secrets.
We should ensure that the token can be used as a bootstrap token, otherwise the yurthub cannot startup.
For example, in my setup, yurtctl select a wrong token(the first one), so it can not get the certificate correctly.

[root@master-1 ~]# kubeadm token list
TOKEN                     TTL         EXPIRES                     USAGES                   DESCRIPTION                                                EXTRA GROUPS
8b9x1o.5ranibmuunw34b5v   55m         2021-09-08T23:04:10+08:00   <none>                   Proxy for managing TTL for the kubeadm-certs secret        <none>
argmko.fxklti113u7t2gvf   22h         2021-09-09T21:04:10+08:00   authentication,signing   The default bootstrap token generated by 'kubeadm init'.   system:bootstrappers:kubeadm:default-node-token
latkt1.a2d6m1zi46gvuflz   22h         2021-09-09T21:04:16+08:00   authentication,signing   <none>                                                     system:bootstrappers:kubeadm:default-node-token

Ref: #384 (comment)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@DrmagicE: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage
/sig storage

/kind bug

What this PR does / why we need it:

When converting cluster with yurtctl convert, yurtctl will try to get the join-token for yurthub from Kubernetes secrets.
We should ensure that the token can be used as a bootstrap token, otherwise the yurthub cannot startup.
For example, in my setup, yurtctl select a wrong token(the first one), so it can not get the certificate correctly.

[root@master-1 ~]# kubeadm token list
TOKEN                     TTL         EXPIRES                     USAGES                   DESCRIPTION                                                EXTRA GROUPS
8b9x1o.5ranibmuunw34b5v   55m         2021-09-08T23:04:10+08:00   <none>                   Proxy for managing TTL for the kubeadm-certs secret        <none>
argmko.fxklti113u7t2gvf   22h         2021-09-09T21:04:10+08:00   authentication,signing   The default bootstrap token generated by 'kubeadm init'.   system:bootstrappers:kubeadm:default-node-token
latkt1.a2d6m1zi46gvuflz   22h         2021-09-09T21:04:16+08:00   authentication,signing   <none>                                                     system:bootstrappers:kubeadm:default-node-token

Ref: #384 (comment)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DrmagicE DrmagicE changed the title bugfix(yurtctl): ensure the join token of yurthub is a bootstrap token bugfix(yurtctl): ensure the join token of yurthub has right usages and groups Sep 30, 2021
@rambohe-ch
Copy link
Member

/lgtm
/approve

@openyurt-bot openyurt-bot added the lgtm lgtm label Sep 30, 2021
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DrmagicE, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/M size/M: 30-99
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants