[XLA:GPU][Indexing] Add documentation about tile analysis. #8810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjoerg
requested changes
Jan 26, 2024
|
|
||
| ### Softmax | ||
|
|
||
|  |
There was a problem hiding this comment.
The HLO fusion seems to contain duplicate code - is this before DCE?
There was a problem hiding this comment.
The reduce-broadcast-subtract-exponential looks identical. We could use the output of exponential1 as input for divide instead, right?
thomasjoerg
approved these changes
Jan 29, 2024
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Jan 29, 2024
Imported from GitHub PR openxla/xla#8810 Indexing analysis is implemented for most of the HLO ops. This document describes, how it works. Copybara import of the project: -- fbd61ef93e8613c54a0273d14e78ff46aca99edf by Alexander Belyaev <[email protected]>: [XLA:GPU][Indexing] Add documentation about tile analysis. -- 787090adafa3b61ef03a5684652e8772d31d7d9e by Alexander Belyaev <[email protected]>: Address the comments -- 720c60c4b5d6ea62e45af42b575b8b8d9dd0fc2e by Alexander Belyaev <[email protected]>: replace % with mod Merging this change closes #8810 PiperOrigin-RevId: 602312874
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indexing analysis is implemented for most of the HLO ops. This document describes, how it works.