Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epic] Add XLA:FFI mechanism to XLA runtime #6335

Closed
ezhulenev opened this issue Oct 14, 2023 · 0 comments
Closed

[Epic] Add XLA:FFI mechanism to XLA runtime #6335

ezhulenev opened this issue Oct 14, 2023 · 0 comments
Assignees
@ezhulenev
Labels
epic GPU XLA on GPU

Comments

@ezhulenev
Copy link
Member

Add XLA:FFI mechanism for extending XLA at run time with "custom calls" with a rich type-safe API.
@ezhulenev ezhulenev added the epic label Oct 14, 2023
@ezhulenev ezhulenev self-assigned this Oct 14, 2023
@copybara-service copybara-service bot mentioned this issue Oct 14, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Oct 16, 2023
@ezhulenev @copybara-github
[xla:gpu] NFC: Remove XLA runtime FFI support from XLA:GPU executable #…
be555a5 
…6335

As a preparation for adding XLA:FFI on top of Thunks runtime remove previous generations of XLA:FFI that was never officially launched.

PiperOrigin-RevId: 573878414
@copybara-service copybara-service bot mentioned this issue Oct 23, 2023
Merged
copybara-service bot pushed a commit that referenced this issue Oct 23, 2023
@ezhulenev @copybara-github
[xla:ffi] Add initial implementation of XLA FFI API and C++ bindings #…
5b5cf3d 
…6335

XLA FFI is a new API unifying xla/runtime/custom_call and xla/runtime/ffi.

1. Stable C API that allows registering external FFI handlers (type safe custom calls with rich C++ API)
2. Header only C++ library to define bindings for C API
3. An internal-only escape hatch for getting access to XLA internals for "internal custom calls" (statically linked libraries)

This is an implementation detail of `API_VERSION_TYPED_FFI` custom call api version (https://github.com/openxla/xla/blob/59c82cdccaf959045053aaa000d819096ad3e0c1/xla/service/hlo.proto#L91-L110)

PiperOrigin-RevId: 575869887
@ezhulenev ezhulenev mentioned this issue Oct 24, 2023
Open
copybara-service bot pushed a commit that referenced this issue Oct 27, 2023
@ezhulenev @copybara-github
[xla:ffi] Add initial implementation of XLA FFI API and C++ bindings #…
def961c 
…6335

XLA FFI is a new API unifying xla/runtime/custom_call and xla/runtime/ffi.

1. Stable C API that allows registering external FFI handlers (type safe custom calls with rich C++ API)
2. Header only C++ library to define bindings for C API
3. An internal-only escape hatch for getting access to XLA internals for "internal custom calls" (statically linked libraries)

This is an implementation detail of `API_VERSION_TYPED_FFI` custom call api version (https://github.com/openxla/xla/blob/59c82cdccaf959045053aaa000d819096ad3e0c1/xla/service/hlo.proto#L91-L110)

PiperOrigin-RevId: 577072278
copybara-service bot pushed a commit that referenced this issue Oct 30, 2023
@ezhulenev @copybara-github
[xla:ffi] Add a static FFI handlers registry #6335
9d4b0cb 
PiperOrigin-RevId: 577688237
@copybara-service copybara-service bot mentioned this issue Oct 30, 2023
Merged
copybara-service bot pushed a commit that referenced this issue Oct 30, 2023
@ezhulenev @copybara-github
[xla:ffi] Add a static FFI handlers registry #6335
a4b3fcc 
PiperOrigin-RevId: 577688237
copybara-service bot pushed a commit that referenced this issue Oct 30, 2023
@ezhulenev @copybara-github
[xla:ffi] Add a static FFI handlers registry #6335
baa8214 
PiperOrigin-RevId: 577872103
copybara-service bot pushed a commit that referenced this issue Oct 30, 2023
@anlunx @copybara-github
[xla:gpu] Disable primitives_test in jitrt_executable_tests #6335
12a9310 
primitives_test triggers error "Typed FFI custom call must be called by XLA runtime" when running in the thunk-based runtime.

PiperOrigin-RevId: 577923273
@copybara-service copybara-service bot mentioned this issue Oct 30, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Oct 31, 2023
@ezhulenev @copybara-github
[xla:ffi] Remove deprecated xla runtime custom modules #6335
6619b60 
PiperOrigin-RevId: 578028138
@copybara-service copybara-service bot mentioned this issue Oct 31, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Oct 31, 2023
@ezhulenev @copybara-github
[xla:ffi] Remove deprecated xla runtime custom modules #6335
31c7e57 
PiperOrigin-RevId: 578040645
@ezhulenev ezhulenev moved this from Todo to In Progress in XLA:GPU Runtime 2024 Oct 31, 2023
copybara-service bot pushed a commit that referenced this issue Oct 31, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI to CustomCallThunk #6335
11ca69b 
It's a very limited support, a lot of xla runtime custom call features are not yet implemented (attributes!)

PiperOrigin-RevId: 578228704
@copybara-service copybara-service bot mentioned this issue Oct 31, 2023
Closed
copybara-service bot pushed a commit that referenced this issue Oct 31, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI to CustomCallThunk #6335
a8f1f51 
It's a very limited support, a lot of xla runtime custom call features are not yet implemented (attributes!)

PiperOrigin-RevId: 578228704
copybara-service bot pushed a commit that referenced this issue Oct 31, 2023
@anlunx @copybara-github
[xla:gpu] Disable primitives_test in jitrt_executable_tests #6335
167133d 
primitives_test triggers error "Typed FFI custom call must be called by XLA runtime" when running in the thunk-based runtime.

PiperOrigin-RevId: 577923273
copybara-service bot pushed a commit that referenced this issue Oct 31, 2023
@anlunx @copybara-github
[xla:gpu] Disable primitives_test in jitrt_executable_tests #6335
8dcc0d7 
primitives_test triggers error "Typed FFI custom call must be called by XLA runtime" when running in the thunk-based runtime.

PiperOrigin-RevId: 578288972
copybara-service bot pushed a commit that referenced this issue Oct 31, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI attributes to CustomCallThunk #6335
3c817a7 
PiperOrigin-RevId: 578257545
@copybara-service copybara-service bot mentioned this issue Oct 31, 2023
Merged
copybara-service bot pushed a commit that referenced this issue Oct 31, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI to CustomCallThunk #6335
5d5855c 
It's a very limited support, a lot of xla runtime custom call features are not yet implemented (attributes!)

PiperOrigin-RevId: 578228704
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI to CustomCallThunk #6335
c6f2ced 
It's a very limited support, a lot of xla runtime custom call features are not yet implemented (attributes!)

PiperOrigin-RevId: 578228704
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI attributes to CustomCallThunk #6335
fc5ebca 
PiperOrigin-RevId: 578257545
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI attributes to CustomCallThunk #6335
fe1cef4 
PiperOrigin-RevId: 578257545
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI to CustomCallThunk #6335
95c2025 
It's a very limited support, a lot of xla runtime custom call features are not yet implemented (attributes!)

PiperOrigin-RevId: 578228704
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI to CustomCallThunk #6335
0d174a3 
It's a very limited support, a lot of xla runtime custom call features are not yet implemented (attributes!)

PiperOrigin-RevId: 578228704
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI attributes to CustomCallThunk #6335
54f8777 
PiperOrigin-RevId: 578257545
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI to CustomCallThunk #6335
ce27ebf 
It's a very limited support, a lot of xla runtime custom call features are not yet implemented (attributes!)

PiperOrigin-RevId: 578379084
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI attributes to CustomCallThunk #6335
3f3e591 
PiperOrigin-RevId: 578257545
copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@ezhulenev @copybara-github
[xla:ffi] Add support for XLA:FFI attributes to CustomCallThunk #6335
b957834 
PiperOrigin-RevId: 578385575
@penpornk penpornk added the GPU XLA on GPU label Feb 29, 2024
@ezhulenev ezhulenev moved this from In Progress to Done in XLA:GPU Runtime 2024 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ezhulenev ezhulenev

Labels
epic GPU XLA on GPU
Projects
XLA:GPU Runtime 2024
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezhulenev @penpornk