Add spec for GetDimensionSizeOp #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smit-hinsu
changed the title
burmako
changed the title
sdasgup3
reviewed
Dec 20, 2022
sdasgup3
approved these changes
Dec 20, 2022
smit-hinsu
force-pushed
the
spec_const
branch
from
e7b916f to
de4027c
Compare
smit-hinsu
force-pushed
the
spec_const
branch
from
de4027c to
011d0b6
Compare
burmako
suggested changes
Dec 21, 2022
burmako
approved these changes
Dec 21, 2022
burmako
pushed a commit
that referenced
this pull request
Jan 24, 2023
Of the two constraints mentioned in #790: * (C1) is already checked by [verifyDimAttr](https://github.com/openxla/stablehlo/blob/main/stablehlo/dialect/StablehloOps.cpp#L117-L120), but have added a negative test * (C2) is not added per discussion [here](#791 (comment)) closes #790
GleasonK
pushed a commit
to GleasonK/stablehlo
that referenced
this pull request
Feb 10, 2023
Of the two constraints mentioned in openxla#790: * (C1) is already checked by [verifyDimAttr](https://github.com/openxla/stablehlo/blob/main/stablehlo/dialect/StablehloOps.cpp#L117-L120), but have added a negative test * (C2) is not added per discussion [here](openxla#791 (comment)) closes openxla#790
atondwal
pushed a commit
to atondwal/stablehlo
that referenced
this pull request
Mar 3, 2023
Of the two constraints mentioned in openxla#790: * (C1) is already checked by [verifyDimAttr](https://github.com/openxla/stablehlo/blob/main/stablehlo/dialect/StablehloOps.cpp#L117-L120), but have added a negative test * (C2) is not added per discussion [here](openxla#791 (comment)) closes openxla#790
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification is missing two constraints. Filed #790 for that.
RFC discussing this op: #194