Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit numerical corner cases #1157

Open
burmako opened this issue Feb 11, 2023 · 0 comments
Open

Audit numerical corner cases #1157

burmako opened this issue Feb 11, 2023 · 0 comments
Labels

Comments

@burmako
Copy link
Contributor

burmako commented Feb 11, 2023

(Please note that this ticket is different from #1156 which talks about numerical accuracy).

When writing the initial version of the spec, we've abstracted ourselves away from numerical corner cases, stating that "Error conditions are [...] possible, e.g. through integer overflows, out-of-bounds accesses, etc. Unless explicitly called out, all these errors result in implementation-defined behavior. [However] as an exception to this rule, floating-point exceptions in StableHLO programs have well-defined behavior [...] defined by the IEEE-754 standard".

This was convenient for the initial version, but this way we not only deferred figuring out error conditions (desired effect) but also missed some interesting corner cases like #1150 (undesired effect). Before we release StableHLO v1.0, it would be good to audit the opset and address both items.

@burmako burmako added the Spec label Feb 11, 2023
burmako pushed a commit that referenced this issue Feb 13, 2023
See #1156 (Decide on speccing numerical accuracy) and #1157 (Audit
numerical corner cases) for more details.
atondwal pushed a commit to atondwal/stablehlo that referenced this issue Mar 3, 2023
See openxla#1156 (Decide on speccing numerical accuracy) and openxla#1157 (Audit
numerical corner cases) for more details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant