Adding Events support in bid responses (WIP) PBID-414, PBID-413, PBID-958 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurb9
changed the title
laurb9
force-pushed
the
events
branch
3 times, most recently
from
04f7d0c to
1849877
Compare
laurb9
force-pushed
the
events
branch
2 times, most recently
from
cfc30bc to
b829081
Compare
…id.events Missing timestamp (waiting for prebid#1584)
- wurl insertion in cached bids - vast modifying in video bids
This avoids unnecessary conversions between json and string ok github.com/prebid/prebid-server/endpoints/events 0.034s coverage: 96.1% of statements
- Fixed comments - Removed redundant types in func proto - Add bool parameter to `ModifyVastXmlString()` to indicate string was changed - Decode RawMessage instead of casting to string (to handle encoded escapes) > ok github.com/prebid/prebid-server/endpoints/events 0.039s coverage: 97.4% of statements
When the VAST is modified to insert the event tracking tag, the modified creative is also returned in the bid response, in addition to being cached. Behavior currently implemented requires targeting enabled. Also renamed eventsData->eventTracking
- all bids have vast modified if account and bidder enabled, not just winning - all NON-VIDEO bids have events if account or request enabled - all cached NON-VIDEO bids have wurl patched in if account or request enabled. prebid#1015 (comment)
prebid#1015 (comment) - all VIDEO bids, cached and returned, have modified VAST if account and bidder enabled - not just winning cached bids. - all NON-VIDEO returned bids have `ext.prebid.events` if account or request enabled - all cached NON-VIDEO bids have `wurl` patched in if account or request enabled.
VAST is modified if *either* account or request setting demanded it. prebid#1015 (comment)
# Conflicts: # exchange/exchange.go # exchange/exchange_test.go
Address prebid#1597 (comment)
# Conflicts: # openrtb_ext/request.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft tracks prebid#1597
Implemented wurl insertion in cached bids, vast rewriting and bid.ext.prebid.events for prebid#1015
Updated and refactored auction_test unit tests for cached bids
Updated exchange_test for bid.ext.prebid.events and vast