DDns Scripts: Rename 'retry_count' to 'retry_max_count' in custom scripts and sample config #25848
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix missed modification of ‘retry_count’ to ‘retry_max_count’ in commit ‘e3292e4c97’ (rename variable: s/retry_count/retry_max_count/). Signed-off-by: FriesI23 Qin <[email protected]>
Fix missed modification of ‘retry_count’ to ‘retry_max_count’ in commit ‘e3292e4c97’ (rename variable: s/retry_count/retry_max_count/). Signed-off-by: FriesI23 Qin <[email protected]>
Fix missed modification of ‘retry_count’ to ‘retry_max_count’ in commit ‘e3292e4c97’ (rename variable: s/retry_count/retry_max_count/). Signed-off-by: FriesI23 Qin <[email protected]>
Fix missed modification of ‘retry_count’ to ‘retry_max_count’ in commit ‘e3292e4c97’ (rename variable: s/retry_count/retry_max_count/). Signed-off-by: FriesI23 Qin <[email protected]>
Fix missed modification of ‘retry_count’ to ‘retry_max_count’ in commit ‘e3292e4c97’ (rename variable: s/retry_count/retry_max_count/). Signed-off-by: FriesI23 Qin <[email protected]>
FriesI23
force-pushed
the
ddns-scripts/fix-retry-max-count
branch
from
932e2b3 to
7a6eff0
Compare
|
Have you considered adding a uci-defaults script to move the old option value into a new one? |
I’m not quite sure how to write and where to place |
|
Please have a look to the following page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: FriesI23 Qin / @FriesI23
Compile tested: should be universal, Debian 12, OpenWrt 23.05.05
Run tested: i386_pentium4, vm on proxmox 8.3 using openwrt.sh, OpenWrt 23.05
Description:
Finish work from "e3292e4" by change remaining
retry_counttoretry_max_count.ddns-scripts: rename variable: s/retry_count/retry_max_count/