-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acme-common: Resolve problem with webroot symlink #25816
base: master
Are you sure you want to change the base?
acme-common: Resolve problem with webroot symlink #25816
Conversation
I can't test right now, but isn't the acme created the .well-known/acme-challenge itself inside of the /var/run/acme/challenge ? CC @tohojo |
Exactly it is how you described, so now link look like that: then acme creates with my change we avoid doubled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, this makes sense; I guess no on tested the existing code?
Please bump the package version as part of the commit, though...
Version updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, better! @stokito are you planning to take this for a spin? :)
I don't have a public IP on a router, but I'll make a tunnel tomorrow and will check. |
Sergey Ponomarev ***@***.***> writes:
I don't have a public IP on a router, but I'll make a tunnel tomorrow
and will check.
Great, thanks!
|
please squash your commits |
38fad69
to
1ca0a87
Compare
acme.sh uses
/var/run/acme/challenge/
as a root of webserver, and automaticly create there.well-known/acme-challenge
while acme request is in progress.Now webroot method should works with no need of any additional config.