Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme-common: Resolve problem with webroot symlink #25816

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bartosz-lab
Copy link

acme.sh uses /var/run/acme/challenge/ as a root of webserver, and automaticly create there .well-known/acme-challenge while acme request is in progress.
Now webroot method should works with no need of any additional config.

@stokito
Copy link
Contributor

stokito commented Jan 23, 2025

I can't test right now, but isn't the acme created the .well-known/acme-challenge itself inside of the /var/run/acme/challenge ?

CC @tohojo

@Bartosz-lab
Copy link
Author

I can't test right now, but isn't the acme created the .well-known/acme-challenge itself inside of the /var/run/acme/challenge ?

CC @tohojo

Exactly it is how you described, so now link look like that:
/www/.well-known/acme-challenge/ -> /var/run/acme/challenge/

then acme creates /var/run/acme/challenge/.well-known/acme-challenge/XXX and from /www folder we have /www/.well-known/acme-challenge/.well-known/acme-challenge/XXX.

with my change we avoid doubled .well-known/acme-challenge/ part

Copy link
Contributor

@tohojo tohojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this makes sense; I guess no on tested the existing code?

Please bump the package version as part of the commit, though...

@Bartosz-lab
Copy link
Author

Right, this makes sense; I guess no on tested the existing code?

Please bump the package version as part of the commit, though...

Version updated

@Bartosz-lab Bartosz-lab requested a review from tohojo January 24, 2025 15:12
Copy link
Contributor

@tohojo tohojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, better! @stokito are you planning to take this for a spin? :)

@stokito
Copy link
Contributor

stokito commented Jan 24, 2025

I don't have a public IP on a router, but I'll make a tunnel tomorrow and will check.

@tohojo
Copy link
Contributor

tohojo commented Jan 24, 2025 via email

@1715173329
Copy link
Member

please squash your commits

@Bartosz-lab Bartosz-lab force-pushed the acme-common_webroot_symlink branch from 38fad69 to 1ca0a87 Compare January 27, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants