Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netatalk: update to 3.2.0 #24257

Merged
merged 1 commit into from
Jun 23, 2024
Merged

netatalk: update to 3.2.0 #24257

merged 1 commit into from
Jun 23, 2024

Conversation

APCCV
Copy link
Contributor

@APCCV APCCV commented May 29, 2024

Maintainer: @APCCV / Antonio Pastor

Commit restores package after it was removed from OpenWrt 21.02.

Compile tested: ipq806x - OpenWrt 23.05.3, r23809

  • Compiled using SDK for 23.05.3.

Run tested: ipq806x - OpenWrt 23.05.3, r23809. Tests included:

  • opkg install of package
  • edit config file to create network shares
  • connect to shares from MacOS (both vintage 10.13 and 14.4)
  • stored, modify and delete files in share from Finder
  • check and update file Information (properties) from Finder
  • configured share to be used for TimeMachine backup
  • create a backup (full backup - initial backup)
  • create incremental backups
  • enter Time Machine and browse backups

Description:
Netatalk package was removed in 2023 as it was stale and used old 3.1.13 version from 2018.
This commit uses the latest stable netatalk version.
A separate PR will be created to take the package out of packages-abandoned.

@APCCV
Copy link
Contributor Author

APCCV commented May 29, 2024

@PolynomialDivision: addressed license issue flagged in previous PR. Linked for reference. Again, apologies for a new PR.

@BKPepe
Copy link
Member

BKPepe commented May 29, 2024

I read your OP, but I am not sure, why this package comes back as it was removed. You could use samba for Time Machine.
This package was removed 3 years ago - #15873 .

@APCCV
Copy link
Contributor Author

APCCV commented May 29, 2024

@BKPepe: MacOS only started supporting Time Machine on SMB shares starting with Mojave (10.14), I think... or maybe even with Catalina (10.15). We have an old iMac running High Sierra (10.13) and it will not see a SMB share for Time Machine. That machine will only Time Machine to an AFP share. Yes, this is a 14 year old machine but it still works and with some care it is safe to use.

On the same OpenWrt device where we are running this package we have samba4 installed and we are backing up more modern MacOS versions to SMB. Not pushing back on using SMB, but AFP is needed for older Macs.

I exchanged messages with the Netatalk dev team, and they are actively maintaining the software. Coincidentally they received another question for netatalk support in OpenWrt (Netatalk/netatalk#562).

@BKPepe
Copy link
Member

BKPepe commented May 29, 2024

For me, it seems like we are trying handle here unique case and in that case, it looks like you are capable to compile it on your own locally or using your feed. Because macOS High Sierra is no longer supported by Apple. 🤷 You could use some e.g. OpenCore Legacy Patcher, if it helps and if it would run flawlessly on your iMac.

@APCCV
Copy link
Contributor Author

APCCV commented May 29, 2024

Running any newer version of MacOS on that iMac will not work well. The GPU does not support Metal. It can be made to boot, and it will then use SMB for Time Machine, but the UI will be very slow.
To address that, OpenCore Legacy Patcher site suggests replacing the video card. This means sourcing a card which is not easy or cheap for what this Mac is, swapping it which also would take substantial effort at considerable risk, and then tweaking the OS to run with it (kext hell). I've run Hackintoshes before and while fun they are not easy to maintain.

I agree this is a niche package, geared for old (14+ years) Macs for Time Machine, and even older for those Macs that don't support SMB. I took this package for granted as I used it way back, but didn't need it while we hobbled along with an old NAS. I'm on it now as I have a spare ipq806x that will replace the NAS. Sure, I can build my own, but I think there would be some demand for it if it was available. The upstream codebase seems actively maintained, and I am willing to set myself as the package maintainer going forward (and learn how to use github and fix those "dirty patches" issues - clearly I'm not sure what I'm doing yet).

I do understand you are looking at the value for the complexity of having yet another package, especially one that was removed 3y ago. I get it. I have what I need, but I think this could be useful to more people than just me. Selfishly, it would also make my life simpler to have an official package instead of having to manually add this in.

@APCCV APCCV changed the title netatalk: update to 3.1.18 netatalk: update to 3.2.0 Jun 10, 2024
@APCCV
Copy link
Contributor Author

APCCV commented Jun 20, 2024

Help please.
This package has two simple patches. I recreated them with diff. I figured out basic quilt and regenerated them again. If I build locally it builds perfectly with no warnings about offsets.
Why do checks fail? Why "Dirty patches detected, please refresh and review the diff"?

@APCCV
Copy link
Contributor Author

APCCV commented Jun 21, 2024

Please approve workflows one more time.
If this finally works then can close this PR and open a new, clean one.

@APCCV
Copy link
Contributor Author

APCCV commented Jun 21, 2024

Oh, great! There we go... one clean commit, no patches to bomb the build, commit starts with name of package to follow standards...
Can we get workflows going and hopefully get a clean set of checks?

Commit restores package after it was removed from OpenWrt 21.02.
Signed-off-by: Antonio Pastor <[email protected]>
@APCCV
Copy link
Contributor Author

APCCV commented Jun 22, 2024

Alright - one last time with feeling. Fixed the commit message so it complies with checks. Hopefully everything will run clean now.

@neheb neheb merged commit 645b04c into openwrt:master Jun 23, 2024
12 checks passed
@APCCV APCCV deleted the netatalk branch June 25, 2024 12:13
@Neustradamus
Copy link

Updated by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants