ooniprobe: update to 3.18.0 #21061
Closed
ooniprobe: update to 3.18.0 #21061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there going to be any progress on this one? |
|
Upstream finally released 3.18.0 which fixed the build for go 1.20. For LFS issue we can still use |
PolynomialDivision
force-pushed
the
ooniprobe
branch
from
b169c0a to
82ce04a
Compare
PolynomialDivision
changed the title
PolynomialDivision
force-pushed
the
ooniprobe
branch
from
82ce04a to
04b74f4
Compare
Release Notes: - https://github.com/ooni/probe-cli/releases/tag/v3.16.6 - https://github.com/ooni/probe-cli/releases/tag/v3.16.7 - https://github.com/ooni/probe-cli/releases/tag/v3.17.0 - https://github.com/ooni/probe-cli/releases/tag/v3.17.1 - https://github.com/ooni/probe-cli/releases/tag/v3.17.2 - https://github.com/ooni/probe-cli/releases/tag/v3.18.0 Manually pass -D_LARGEFILE64_SOURCE to allow to keep using LFS64 definitions. Signed-off-by: Nick Hainke <[email protected]>
PolynomialDivision
force-pushed
the
ooniprobe
branch
from
04b74f4 to
e57bd98
Compare
|
I can not run test that since my flash is not big enough. I would vote for merging this so buildbot finally builds this package again. |
1715173329
approved these changes
Jul 7, 2023
tbh the most binaries in this package are just garbage. |
|
No way. I dont think that this is good approach as it shows our
contributors that they can send even untested PRs as we dont care about
quality. :-(
The better question why are sending PRs, which are not tested and they can
not be tested on your side since you dont have router with such storage to
be able to install it. Of course, everyone can do that. But whats the point
doing that? Having good looking statistics on GitHub?
What if your PR will cause anything on the router itself? Users will be
using this package and after this PR, they will get segfaults. Imho thats
not wanted. To be honest, I can do it, too. However, I am not doing that,
because I dont like it.
Please just stop doing that.
Dne pá 7. 7. 2023 14:55 uživatel Nick Hainke ***@***.***>
napsal:
… I can not run test that since my flash is not big enough. I would vote for
merging this so buildbot finally builds this package again.
—
Reply to this email directly, view it on GitHub
<#21061 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7IDVGRYAFYN6JG7WCPVULXPABNVANCNFSM6AAAAAAYESLGMI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Superseded by this #21557 |
|
My apologies, I should have checked for existing PRs before opening mine 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
Maintainer: @ja-pa
Compile tested: CI
Run tested: no