libgd: fix building with freetype support #10943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a PKG_RELEASE bump. |
Freetype support is required for php7-mod-gd as of commit 0f10c8c, which causes the PHP7 package to build using this external libgd library. This commit adds FREETYPE_INCLUDE_DIRS to the definition of CMAKE_OPTIONS. Without this, libgd does not build freetype support as shown by this message: .... Build libgd: -- Could NOT find Freetype (missing: FREETYPE_INCLUDE_DIRS) -- Configuring done -- Generating done .... Signed-off-by: W. Michael Petullo <[email protected]>
|
Bumped PKG_RELEASE, and force pushed. |
|
I've edited the PR template a little bit, other than this, this LGTM. |
|
Merging since technically I broke this with the conversion to CMake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @jow-
Compile tested: arm/mxs (by @mhei )
Run tested: -
Description:
Freetype support is required for php7-mod-gd as of commit 0f10c8c,
which causes the PHP7 package to build using this external libgd library.
This commit adds FREETYPE_INCLUDE_DIRS to the definition of CMAKE_OPTIONS.
Without this, libgd does not build freetype support as shown by
this message:
....
Build libgd:
-- Could NOT find Freetype (missing: FREETYPE_INCLUDE_DIRS)
-- Configuring done
-- Generating done
....
Signed-off-by: W. Michael Petullo [email protected]