luci-mod-network: validate DHCP leasetime input #7455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feckert
reviewed
Dec 6, 2024
modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js
Outdated
Show resolved
Hide resolved
morse-lyall
force-pushed
the
validate-dhcp-server-leasetime-input
branch
from
705e56b to
1032ca1
Compare
Without validation, `dnsmasq` can fail silently if users enter invalid leasetime input. This change adds input validation to align user input with the backend parsing logic. Whilst it does not enforce the >120 seconds requirement, this is documented in the field description and handled by `dnsmasq`'s `option.c`, which adjusts values <120 to meet this minimum. Signed-off-by: Lyall Beveridge <[email protected]>
morse-lyall
force-pushed
the
validate-dhcp-server-leasetime-input
branch
from
1032ca1 to
8b3da44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without validation,
dnsmasqcan fail silently if users enter invalid leasetime input. This change adds input validation to align user input with the backend parsing logic. Whilst it does not enforce the >120 seconds requirement, this is documented in the field description and handled bydnsmasq'soption.c, which adjusts values <120 to meet this minimum.Signed-off-by: <[email protected]>row (viagit commit --signoff)<package name>: titlefirst line subject for packagesPKG_VERSIONin the Makefile