build: use new imagebuilder setup.sh for appropriate versions #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efahl
force-pushed
the
prep-24.10
branch
2 times, most recently
from
6c15ad8 to
abbf8f0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
==========================================
+ Coverage 80.75% 90.15% +9.40%
==========================================
Files 15 14 -1
Lines 977 1189 +212
==========================================
+ Hits 789 1072 +283
+ Misses 188 117 -71 ☔ View full report in Codecov by Sentry. |
|
@aparcar you might want to get this one in, as it allows the ASU server to build the 24.10 RCs, which are broken without it... |
aparcar
reviewed
Dec 3, 2024
aparcar
reviewed
Dec 3, 2024
efahl
force-pushed
the
prep-24.10
branch
2 times, most recently
from
029edb9 to
62ffde7
Compare
Properly detect versions for which the slim imagebuilder containers using setup.sh is being used. Set up the container accordingly. Signed-off-by: Eric Fahlgren <[email protected]>
|
Rebased. Ends up not fixing anything, but the general cleanup and added tests are probably worth keeping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly detect versions for which the slim imagebuilder containers using setup.sh is being used. Set up the container accordingly.
Allows building the new 24.10 versions, including the RCs.