-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwrite FileResponse Content-Type with application/octet-stream for all files in /store #1064
base: main
Are you sure you want to change the base?
Conversation
Should these be squashed? @aparcar |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1064 +/- ##
==========================================
+ Coverage 80.75% 90.47% +9.71%
==========================================
Files 15 15
Lines 977 1123 +146
==========================================
+ Hits 789 1016 +227
+ Misses 188 107 -81 ☔ View full report in Codecov by Sentry. |
from asu.config import settings | ||
from asu.fastapi.staticfiles import FileResponse | ||
|
||
store_path = settings.public_path / "store" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ugly.
But conftest.py overwrites settings.public_path, unfortunately the main.py/app has already been constructed, with the previous old public_path.
Thus the conftest.py app()-setting of public_path to a temp-path doesn't work here.
Could you please try again and see if the issue is resolved? If so the Caddy docs are broken, caddy is broken or I misunderstand some stuff, however it worked on my test run with Firefox |
Fixes #1059