[change] User Model Extension (Bulk Update)

[chanduaki]

Extending User Models in openwisp-radius
I have followed the documentation(https://github.com/openwisp/openwisp-users/#extend-openwisp-users) to extended the User models. But when we extend the User models here

Are these fields will add in Bulk User creation ( through csv we are doing according to https://openwisp-radius.readthedocs.io/en/latest/user/importing_users.html)

But when i have in the code itself , only considering the below fields to create or update the user according to

openwisp-radius/openwisp_radius/base/models.py

Line 942 in e6b931a

def get_or_create_user(self, row, users_list, password_length):

    User = get_user_model()
    username, password, email, first_name, last_name = row

This was seen in multiple places , fixing the fields in the Bulk User creation

Do we need to make changes in the core code or is there any other way to extend them

I think code needs to be improved

[nemesifier]

I think we should add an additional method there which by default is empty but can be used by third party apps to add their own logic.

Eg:

    ...
    user = self.customize_user_creation(user, row)
    user.full_clean()

def customize_user_creation(user, row):
     return user

Third parties should be able to extend customize_user_creation to do add the custom fields.

We should create a test for this use case in the SAMPLE_APP: https://github.com/openwisp/openwisp-radius/tree/master/tests/openwisp2/sample_radius

[eleensmathew]

Hi can i work on this? Since i am new can you please explain the issue and its solution in simple terms?

[codesankalp]

You can start working @eleensmathew

[codesankalp]

Since i am new can you please explain the issue and its solution in simple terms?

If you are new, please try to explore openwisp-radius first.

[eleensmathew]

Should I add this code (#310 (comment)) in the https://github.com/openwisp/openwisp-radius/blob/master/tests/openwisp2/sample_radius/models.py file?