Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] Add options in Makefile + Documentation #42

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

atb00ker
Copy link
Member

@atb00ker atb00ker commented Jul 5, 2019

  1. Add options in the Makefile for development and travis builds.
  2. Add documentation of the options added in the README.md.

Related #25

@atb00ker atb00ker force-pushed the makefile branch 3 times, most recently from bec7b7a to 782c4a3 Compare July 12, 2019 03:32
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it normal that the travis build is failing?

Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the rest LGTM

@atb00ker
Copy link
Member Author

atb00ker commented Jul 13, 2019

is it normal that the travis build is failing?

That's because of the new changes in the django-freeradius repository. When those changes are incorportaed in openwisp-radius, it will work. i.e waiting for openwisp/openwisp-radius#54 then I'll restart travis and it should work. 😄

@nemesifier
Copy link
Member

openwisp/openwisp-radius#54 merged

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@nemesifier nemesifier merged commit 7bae5e2 into openwisp:master Aug 2, 2019
@atb00ker atb00ker deleted the makefile branch August 17, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants