Bugfix realAllUnder for collection and map with complex field path

[florianlacreuse]

No description provided.

[yrodiere]

Seems like I did something wrong indeed. I may also have forgot to include a test for this case...

Anyway, while this commit would probably fix the immediate problem, a better course of action might be to add a "parentModel" to each BindableModel (except the root and collection items), and use that parent instead of propertyModelsByImpactingPaths for read event propagation. The readAllUnder method would now simply be a bind(bindingRoot).readAll() and readAll would now include a loop akin to BindableModel parent = parentModel ; while (parent != null) { parent.read() /* Not readAll */; parent = parent.parentModel; }. This would ensure that, when a model was registered as Bindings.a().b().c(), using the model for B and calling readAllUnder(Bindings.b().c()) would still trigger a read on the model for A.

[yrodiere]

Something is still wrong with my previous comment. The "read" loop should trigger reads from the top down, so it should do something like:

void propagateReadToParent() {
  if (parentModel != null) {
    parentModel.propagateReadToParent();
  }
  read();
}

public void readAll() {
  propagateReadToParent();
  // ... do stuff that's already done in the current code
}

[lalmeras]

This fix needs to be refactored to address Yoann advices.