Fix instructor feedback not being given when showPartialCorrectAnswers is false. #2307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
bugfix/instructor-feedback-showparicalcorrect
branch
2 times, most recently
from
be72eda to
98af641
Compare
…s is false. This applies to problems rendered in the library browser or PG problem editor. In that case if $showPartialCorrectAnswers is false, then the instructor is not given the problem status (correct/incorrect) in the feedback. This is because the renderProblem method does not set the forceShowAttemptResults (which overrides the $showPartialCorrectAnswers variable in PG) option. So that is fixed by setting that option from the submit buttons for instructors.
drgrice1
force-pushed
the
bugfix/instructor-feedback-showparicalcorrect
branch
from
98af641 to
f207ecf
Compare
pstaabp
approved these changes
Feb 7, 2024
drdrew42
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to problems rendered in the library browser or PG problem editor. In that case if $showPartialCorrectAnswers is false, then the instructor is not given the problem status (correct/incorrect) in the feedback. This is because the renderProblem method does not set the forceShowAttemptResults (which overrides the $showPartialCorrectAnswers variable in PG) option. So that is fixed by setting that option from the submit buttons for instructors.