Adjust ADD_JS_FILE handling code to deal with new third parameter #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
method to add attributes provided in the new optional third argument. The code is also adjusted to ensure that scripts are loaded in the order that they are requested, instead of in the random order that perl gives with hash keys. Should this be done with the ADD_CSS_FILE handling code also? Order matters for css loading as well.
taniwallach
added
NeedsTesting
taniwallach
reviewed
May 26, 2021
drgrice1
pushed a commit
that referenced
this pull request
May 27, 2021
Adjust ADD_JS_FILE handling code to deal with new third parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the code for dealing with the files added by PG.pl's ADD_JS_FILE method to add attributes provided in the new optional third argument.
The code is also adjusted to ensure that scripts are loaded in the order that they are requested, instead of in the random order that perl gives with hash keys. Should this be done with the ADD_CSS_FILE handling code also? Order matters for css loading as well.
This is paired with openwebwork/pg#576.