Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Achievement item that cannot be used #2279

Closed
Alex-Jordan opened this issue Dec 12, 2023 · 1 comment
Closed

Achievement item that cannot be used #2279

Alex-Jordan opened this issue Dec 12, 2023 · 1 comment

Comments

@Alex-Jordan
Copy link
Contributor

If you have an achievement item, but it cannot presently be used (e.g. it only applies to open sets and there are none right now) then either the button to use that item should be disabled, or if you click it you should get a special message. Right now you click it and get empty select menus.
drgrice1 added a commit to drgrice1/webwork2 that referenced this issue Jan 16, 2024
@drgrice1
If an achievement item can not be used, then disable the "Use Reward"…
b0071ec 
… button.

This fixes issue openwebwork#2279.

For now this just makes the "Use Reward" button disabled if there are no
sets that the achievement item can act one.  With a little more effort a
message could be shown when the button is clicked instead.
drgrice1 added a commit to drgrice1/webwork2 that referenced this issue Jan 16, 2024
@drgrice1
If an achievement item can not be used, then disable the "Use Reward"…
0ea994d 
… button.

This fixes issue openwebwork#2279.

For now this just makes the "Use Reward" button disabled if there are no
sets that the achievement item can act one.  With a little more effort a
message could be shown when the button is clicked instead.
drgrice1 added a commit to drgrice1/webwork2 that referenced this issue Jan 24, 2024
@drgrice1
If an achievement item can not be used, then disable the "Use Reward"…
7af4c8e 
… button.

This fixes issue openwebwork#2279.

For now this just makes the "Use Reward" button disabled if there are no
sets that the achievement item can act one.  With a little more effort a
message could be shown when the button is clicked instead.
@pstaabp pstaabp mentioned this issue Jan 25, 2024
Merged
drgrice1 added a commit to drgrice1/webwork2 that referenced this issue Feb 2, 2024
@drgrice1
If an achievement item can not be used, then disable the "Use Reward"…
833a81e 
… button.

This fixes issue openwebwork#2279.

For now this just makes the "Use Reward" button disabled if there are no
sets that the achievement item can act one.  With a little more effort a
message could be shown when the button is clicked instead.
pstaabp added a commit that referenced this issue Feb 7, 2024
@pstaabp
Merge pull request #2299 from drgrice1/achievement-item-problem-ids
e1c4a15 
Fix achievement issues #2281 and #2279
@pstaabp
Copy link
Member

pstaabp commented Feb 21, 2024

Fixed in #2299

@pstaabp pstaabp closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pstaabp @Alex-Jordan