Skip to content

Commit

Permalink
Move the ConfigValues array out of defaults.config.
Browse files Browse the repository at this point in the history
This array is now defined in `lib/WeBWorK/ConfigValues.pm` and is
returned by the `getConfigValues` method.  The `$LTIConfigValues` hash
is also defined in that file and added to the array when
`getConfigValues` is called if LTI authentication is enabled for the
course.  This means that these are no longer configurable.  No config
file can modify them. Furthermore, the array is not even ever added to
the course environment.  Instead it is just used by the course
configuration module which is the only place it was ever used.

This means that if a course's course.conf file includes authen_LTI.conf,
it does not also need to include the LTIConfigValues.config file.  That
file in fact no longer exists.

Also remove all access to the `paramcache` outside of the
`WeBWorK::Controller` module.  That is an internal implementation detail
that should never be accessed directly outside of that file.
  • Loading branch information
drgrice1 committed Mar 27, 2024
1 parent d92d4be commit 6a7c5b5
Show file tree
Hide file tree
Showing 9 changed files with 1,101 additions and 1,125 deletions.
3 changes: 1 addition & 2 deletions bin/dev_scripts/update-localization-files
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ cd $LOCDIR

echo "Updating $LOCDIR/webwork2.pot"

xgettext.pl -o webwork2.pot -D $WEBWORK_ROOT/lib -D $WEBWORK_ROOT/templates \
$WEBWORK_ROOT/conf/defaults.config $WEBWORK_ROOT/conf/LTIConfigValues.config
xgettext.pl -o webwork2.pot -D $WEBWORK_ROOT/lib -D $WEBWORK_ROOT/templates

if $UPDATE_PO; then
find $LOCDIR -name '*.po' -exec bash -c "echo \"Updating {}\"; msgmerge -qUN {} webwork2.pot" \;
Expand Down
106 changes: 0 additions & 106 deletions conf/LTIConfigValues.config

This file was deleted.

Loading

0 comments on commit 6a7c5b5

Please sign in to comment.