-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revised handling of PERSISTENCE_HASH data #809
Conversation
This is initially intended to allow saving "state" of scaffolds so I can resume work on #506 however it will support any other data a problem author might want to remain available. I think it should provide a better mechanism to support file (image uploads) as envisioned in #482 than in the The problem author decides when data gets stored into the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally looks good, but I have a few suggestions that I think clarify the usage of the new methods added.
and to allow update and get operations. The webwork2 side will now store this in a special field. Includes changes and suggestions from Dr. Glenn Rice. See: openwebwork#809
782dd66
to
0a4e3f8
Compare
and to allow update and get operations. The webwork2 side will now store this in a special field. Includes changes and suggestions from Dr. Glenn Rice. See: openwebwork#809
0a4e3f8
to
4b947ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Persistent problem data - modify to retrieve from
$envir
and to allow update and get operations.Paired with openwebwork/webwork2#1940
The webwork2 side will now store this in a special field.