reduce extra digit checking in digits toltype #558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the default on this should be more loose, as close as it can be to the current relative tolerance defaults. This change means you must have the first three digits right (not counting trailing zeros which may always be omitted) and then if you give a 4th digit, it must be right. But now there will be no checking beyond that 4th digit. Assuming truncation or rounding are both set to be permitted, for π, these would now be correct:
3.14
3.141\d*
3.142
and these would now be incorrect:
3.15
3.14[^12]\d*
3.142\d+
A change is that, for example, 3.1417 is not correct by default before this change, but now it would be.