Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for PTX output from GraphTool #553

Merged
merged 1 commit into from
Mar 23, 2021

Conversation

Alex-Jordan
Copy link
Contributor

GraphTool was assuming output is either TeX or some flavor of HTML. This accounts for PTX, in which case it outputs nothing, which is fine for now. Without this edit, there is an assumption of some flavor of HTML output, and HTML comes out mixed in with PreTeXt XML.

We really need some method that says "if the output is HTML" without directly using $displayMode in code like this. Something that captures the $displayMode variants like MathJax, images, and whatever else remains. But this small thing here is fine for now.

Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I am never quite sure what to do about PTX output. I guess it should have been obvious not to output HTML stuff though. I also tend not to think about it as I don't use it. I count on you to fix that!

@drgrice1 drgrice1 merged commit 88e9bfa into openwebwork:PG-2.16 Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants