Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreTeXt: remove sidebyside #542

Merged

Conversation

Alex-Jordan
Copy link
Contributor

This is catching up with PreTeXt developments. Formerly, PTX did not allow tabular, image or video elements without certain wrappers like figure, table, and sidebyside. We never allowed the first two as WW output, and used sidebyside as the wrapper in all cases. Now this practice is not needed. PTX allows "naked" tabular, image and video elements. Clearing away all the sidebyside stuff simplifies this WW code, and also prevents PTX from issuing warnings that it detects a pointless sidebyside.

I'd like to include this in 2.16. I suspect no one else who is active would want to test PreTeXt stuff. If you would like to review this, I suggest just eyeing the code edits to see that I didn't leave a < somewhere where it should have been cut, and typos like that.

Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these changes only change the PTX display format, I can approve this without extensive testing. I tested to make sure that problems using these macros still work. Mainly just to ensure there aren't any syntax errors introduced, as that is the only thing that would cause problems for other display formats.

@drgrice1 drgrice1 merged commit ed0ca5b into openwebwork:develop Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants