Fix problem with decimals with no leading 0 (#525) #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual tokens to be prioritized in the pattern list, and use that to put the dot product pattern after the number pattern. Resolves issue openwebwork#525.
drgrice1
approved these changes
Feb 16, 2021
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Jun 1, 2023
The only thing the override did was call the `update` method to force patterns to be updated. This is no longer needed since uddate is now always called by the SUPER method when tokens are added. This was changed in openwebwork#518 and openwebwork#526.
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Jun 7, 2023
The only thing the override did was call the `update` method to force patterns to be updated. This is no longer needed since uddate is now always called by the SUPER method when tokens are added. This was changed in openwebwork#518 and openwebwork#526.
drgrice1
added a commit
to drgrice1/pg
that referenced
this pull request
Jun 8, 2023
The only thing the override did was call the `update` method to force patterns to be updated. This is no longer needed since uddate is now always called by the SUPER method when tokens are added. This was changed in openwebwork#518 and openwebwork#526.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
patternPrecedenceproperty to context items that allows individual tokens to be prioritized in the pattern list. It then uses that to put the.operator pattern after the number pattern, so that decimal numbers with no leading zero will be identified first, and then if.is not used as a decimal, it will be recognized as a dot product.Without the patch,
Compute(".123")produces an error about a missing operand for.but with the patch, it should produce .123 as expected. Alsoshould produce an output of 11.
Resolves issue #525.