Properly add parentheses to Fraction::Value objects based on precedence. #512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Fraction MathObjects may lose necessary parentheses when stringified or texified. For example
Compute("x^(2/7)")->string;
will producex^2/7
. This means thatwould produce
$g
equivalent toCompute("(x^2)/7")
rather than equivalent to$f
. (See this Forum post for more details.)This PR resolves the issue by overriding the
string()
andTeX()
methods to properly insert parentheses when needed. These are added when the operator precedences require it, or (instring()
) when the original had them (since the TeX version is a vertical fraction, they are are only added when precedence requires it).To test, use