-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update answerHints to not produce hints in Preview mode #476
Conversation
This seems to work as expected, including all the configuration/override switches, and that is a big improvement over the simple hack I had proposed in #468 . I tested with the sample file from: #468 and then made some revisions to test with the switches. As expected, by default - preview no longer shows the message. Adding
showed that Adding Revised test file with use of switches:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and working properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected. I am just not sure what is going on with lines 126-130.
Merging and closing #379 |
This PR adjusts the
answerHints
macro to not produce answer hints in preview mode unless a flag is set allowing that.See #468.