Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix malformed utf8 copyright errors caused by the © character #469

Merged
merged 1 commit into from
May 17, 2020

Conversation

drgrice1
Copy link
Member

@drgrice1 drgrice1 commented May 12, 2020

Switch from © to © in all pg macro files where this had not been done already. These can cause malformed utf-8 character errors for problems. This was seen in problems that use the contextPolynomialFactors.pl macro.

This could probably be considered to be added to the master branch. This should have been done when the switch to utf-8 was made.

malformed utf-8 character errors for problems.  This was seen in a
problem that uses the contextPolynomialFactors.pl macro.
@mgage
Copy link
Member

mgage commented May 17, 2020

I wasn't able to trigger an error on my laptop installation using Library/CollegeOfIdaho/setAlgebra_05_06_Factoring/56IntAlg_29_Factor.pg
and a develop branch before the patch was applied.

However this is clearly a patch that should be applied. There were no
errors after the patch.

@mgage mgage merged commit ab3d2ef into openwebwork:develop May 17, 2020
@mgage
Copy link
Member

mgage commented May 17, 2020

I'm not sure that it's urgent that this be a hotfix.

Unless someone can give a specific example where this is causing trouble in the master 2.15 branch we can just wait until the is develop branch becomes 2.16

@drgrice1
Copy link
Member Author

I should note that I was not able to reproduce this using a user with professor (or above) permissions. It only occurred with a student account. It also only occurs in a course with a database that is fully upgraded to utf8mb4. If I import a course that was originally created before the database upgrade and don't upgrade all tables, it does not occur. That is most likely because the database is still really using the old character set. To really upgrade the database, you need to go through each table and change its character set. So try this with a newly created course on WW-2.15 using a student account.

@drgrice1 drgrice1 deleted the fix-malformed-utf8-copyright branch May 18, 2020 13:20
@drgrice1
Copy link
Member Author

It is possible that a hot fix is needed. See issue #493.

@drgrice1 drgrice1 mentioned this pull request Aug 20, 2020
@taniwallach
Copy link
Member

Hotfix is in #500 and was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants