Prevent images from being regenerated again under a new alias #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
than a package variable. Since the new method is called and initializes this property to the empty hash on each successive run, this prevents carry over of old values. That carry over caused unnecessary regeneration of images under new aliases.
drgrice1
force-pushed
the
image-regeneration-fix
branch
from
10164fb to
0b657bd
Compare
resource object name in getUniqueName of PGcore.pm. All of that information and more is already incorporated into the generated uuid by PGalias. The image number count doesn't need that information either. The names_created property is now just a numeric value rather than a hash. Each problem has its own PG object anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make names_created in PGcore.pm a property of the PGcore object rather than a package variable. Since the new method is called and initializes this property to the empty hash on each successive run, this prevents carry over of old values. That carry over caused unnecessary regeneration of images under new aliases.
Note, that I have removed the gifs_created property of the PGcore object that was completely unused.