Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert vectors to column matrices for some matrix operations. #307

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Jul 1, 2017

For the MatrixReal1 macros that require column vectors, convert vectors to column matrices. This is for normalize(), solve_LR(), and other solve macros.

To check, use

TEXT(join(', ',Matrix([1,2],[3,4])->normalize(Vector(1,2))));
TEXT(join(', ',Matrix([1,2],[3,4])->solve_LR(Vector(1,2))));

Without the patch, these will throw errors. With the patch, they should succeed.

@mgage
Copy link
Member

mgage commented Jul 7, 2017

This passes the tests.

@mgage mgage merged commit 8f22d5f into openwebwork:develop Jul 7, 2017
@dpvc dpvc deleted the matrix-fix branch July 20, 2017 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants