spelling typo in hash key #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching that. I approve the change. I'm not sure the protocol these days: should I merge, or does that take more review? |
|
Hi Davide,
Go ahead and merge Davide. We’re a little short handed on maintainers at the moment.
I’d still like to keep
a protocol where at least two people have looked at a pull request (the submitter and one other) before it’s pulled.
Today was the first day of classes, and we also just put up a new webwork server on a new operating system
(OEL) so I’ve been a bit overloaded. I’m hoping to get to pull requests this weekend but you can take this one.
Take care,
Mike
|
|
I will look at the other MathObject-based PRs as soon as I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.