Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Numbering Bug #279

Merged
merged 1 commit into from
Aug 20, 2016
Merged

Error Numbering Bug #279

merged 1 commit into from
Aug 20, 2016

Conversation

goehle
Copy link
Member

@goehle goehle commented Aug 4, 2016

This changes the white space character in the pg code preprocessing regexs to the horizontal whitespace character. This has the affect of not removing blank lines from preprocessed code and means that the error numbers reported by PG will match the lines in the PG problem.

To test:

  • Check that problems still work. Mike/Davide may have an opinion if the full \s is necessary for preprocessing.
  • Try the following problem. Before the patch the error will be reported on line 5. After it will be reported with the correct line 7
DOCUMENT();

BEGIN_TEXT
spoon
END_TEXT

,difl.poeldjva;

ENDDOCUMENT(); 

@mgage
Copy link
Member

mgage commented Aug 20, 2016

Looks good. Nice catch on this long standing annoying but not fatal error.

@mgage mgage merged commit e34621f into openwebwork:develop Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants