-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.5.1 release candidate? #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the definition of courseNames so that createTmpDirectory would not fail on courses names with hyphens
…ectory so that courseNames with hyphens work.
to remove the last node. (That version actually did this correctly.)
Changes made to PGresources so that pointers to the html files used in the problem are pointed to.
moved from PGcore and PGalias back to Problem.pm and printed to the screen. A better fix will be to create a storarge array in PG.pl and pass that address to PGcore when it is created for use in storing warning (resp. debug) messages. When PGalias, and the other PG subclasses of PGcore are created they will also be pointed to the same storage location by their parent.
…s for an auxiliary html file. If the file is not already publically accessible a link is created using a uuid.
…course name is changed the link name is changed as well.
…core object itself and not stored under the flags hash. Make sure compatible changes are made in Problem.pm
…->{flags}) Earlier the warning/debug queues for PGalias were tied to those for PGcore so no transfer of messages is needed. This still needs testing. FIXME: Translator.pm, in the commented out statements, should be using the methods of PGcore to access messages rather than doing it directly. This seems to be ok in PG.pl and also in Problem.pm where these messages are retrieved.
For now this consisted of changing $useOldMacros to $main::useOldmacros in FUN_CMP and NUM_CMP. I also hacked some warning labels about answer labels being undefined. This is probably still broken and means that the warning about repeating the same answer will not work for these problems. This answer checker should be replaced by direct calls to MathObjects
…iles This may have already been fixed in updates from apizer
These warning messages alerted you to when resources were being added.
This pull request doesn't merge automatically. |
* commit 'dd2c97c8bf14e9789224e4f1d308035fc16ec05b': Fixed the tmp directory bug that affected courses with a - in the name. This updated the git version to what is in svn. This error had been fixed in pg/lib/WeBWorK/PG/IO.pm. This merge updates PGcore.pm to use the routine directoryFromPath where the the final node of path was removed correctly. Conflicts: lib/PGcore.pm
mgage
added a commit
that referenced
this pull request
Sep 7, 2012
Current set of corrections from DPVC
mgage
pushed a commit
that referenced
this pull request
Sep 7, 2012
Fix issue with preprocessing .pg files included using includePGtext()
mgage
added a commit
that referenced
this pull request
Sep 7, 2012
pull request for changes incorporating dragmath editor
goehle
pushed a commit
that referenced
this pull request
Aug 22, 2013
Merged the openwebwork/develop branch up to July 12
mgage
added a commit
that referenced
this pull request
Jan 25, 2014
catch my repo up with openwebwork
mgage
pushed a commit
that referenced
this pull request
Jun 13, 2020
Fix problem with RTL multiplication, and make it apply to numbers on the right
drgrice1
pushed a commit
that referenced
this pull request
Apr 13, 2021
Improve the generated POD output from PGbasicmacros.pl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bugs are slowly being moved out of this. Be sure to read the README in the conf directory and to move your global.conf file to global.save before installing this version.