PG 2.19 Release Candidate #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructure how answer names are associated with answer evaluators.
address issue #951
100% translated source file: 'lib/WeBWorK/PG/Localize/pg.pot' on 'el'.
100% translated source file: 'lib/WeBWorK/PG/Localize/pg.pot' on 'el'.
100% translated source file: 'lib/WeBWorK/PG/Localize/pg.pot' on 'el'.
100% translated source file: 'lib/WeBWorK/PG/Localize/pg.pot' on 'el'.
100% translated source file: 'lib/WeBWorK/PG/Localize/pg.pot' on 'el'.
100% translated source file: 'lib/WeBWorK/PG/Localize/pg.pot' on 'el'.
100% translated source file: 'lib/WeBWorK/PG/Localize/pg.pot' on 'el'.
100% translated source file: 'lib/WeBWorK/PG/Localize/pg.pot' on 'el'.
…a4294 Updates for file lib/WeBWorK/PG/Localize/pg.pot in el
avoid an error from misuse of 'AnSwEr'
This is as discussed in #939 (post merge).
This adds `showHints => 0`, `showLengthHints => 0`, and `partialCredit => 0` to the `cmp_defaults` for `CheckboxList` answers. For now this adds all of them, but that can be changed as the discussion evolves. See issue #971.
Tweaks to the `cmp_defaults` for `parserCheckboxList.pl`
Change the color of the message dot on the feedback button to yellow.
…ner css classes. Using `align-middle` and `align-bottom` can conflict with the bootstrap classes with the same name. The feedback alignment classes are different in that they align the feedback button relative to the feedback container, and the bootstrap classes align the container itself. Note that these classes are not used internally by pg (at this point), but are provided for authors using MultiAnswer's with `singleResult` true that want to position the feedback button relative to the feedback container. Also note that there is no `align-top` because that is the default behavior for the `ww-feedback-btn`.
The following dependencies were updated. * plotly.js-dist-min from 2.18.2 to 2.27.0 * autoprefixer from 10.4.13 to 10.4.16 * cssnano from 6.0.0 to 6.0.1 * rtlcss from 4.0.0 to 4.1.1 * sass from 1.57.1 to 1.69.5 * terser from 5.16.1 to 5.24.0 * yargs from 17.6.2 to 17.7.2 * jsxgraph from 1.5.0 to 1.6.2 Most versions of these libraries are compatible with pg's current usage and require no changes to the code. The exception is jsxgraph. Most of the the changes are compatible with the current usage. However, the fullscreen mode has changed in a way that breaks the graphtool usage. So now the graphtool javsacript handles fullscreen mode using its own code. This is better than it was before in any case. There were several issues that are resolved with this. Particularly resize issues related to screen rotation on mobile devices, and enabling or disabling help after switching to fullscreen. Now all JavaScript dependencies are at their newest versions.
… not just the first. All of @somiaj's suggested escape code comments in #1980 contained the `g` flag on the regular expression, but when #878 was actually committed, the code did not. As a result only the first character on the line will actually be escaped. This results in rather unexpected MathJax rendering. For example, if the line contains ``` `x + y = 3` and `x - y = 4` ``` then this is rendered as ``` <span class="text2jax_ignore">`</span>x + y = 3` and `x - y = 4` ``` Which results in `` ` and ` `` being rendered by MathJax.
For PGML escape all characters (\, `, and $) in a line of html output not just the first.
Update third party JavaScript dependencies.
…date Update feedback popover position when typing in a MathQuill input.
This fixes openwebwork/mathquill#30. Although, I am not sure what is going on here. For some reason delaying filling in previous answers until the "next tick" (a timeout with 0 delay) fixes the problem. Probably the MathQuill math field is not fully initialized until after the mqeditor setup method completes. I am unable to reproduce the issue using the development build of MathQuill directly via `npm run serve`.
This seems to help some.
The console logging issue has been fixed, and the intermediate grid bug (that was in the versions between where PG-2.19 now is and this) has also been fixed.
adjust by larger amount in 'digits' comparisons
add an alternative 'such that' pipe
…xt-tick Add previous answers to MathQuill inputs on the next tick.
Update JSXGraph to the latest version.
The pg environment variable is now `$externalPrograms{latex2pdf}`.
This was changed as discussed in the development meeting today because
it is odd for it to be named pdflatex if we are not using pdflatex, and
to match the corresponding webwork2 change.
add showInStatic option to radio buttons
Switch the default latex variant to xelatex.
attempt to parse display math for proper PTX md/mrow structure when a…
consistent PTX multiple choice structure
reduction rule for m(nx)->(mn)x
let width specifications in niceTables be numbers from (0,1]
pstaabp
previously approved these changes
Aug 6, 2024
somiaj
approved these changes
Aug 6, 2024
drgrice1
dismissed
pstaabp’s stale review
The merge-base changed after approval.
Alex-Jordan
approved these changes
Aug 6, 2024
dlglin
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As usual, target pull request to this branch if you want it to go into the release.