Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with MathObjects reduction #455

Closed
Alex-Jordan opened this issue Feb 27, 2020 · 7 comments
Closed

bug with MathObjects reduction #455

Alex-Jordan opened this issue Feb 27, 2020 · 7 comments
Labels
MathObject issue Issue involving MathObects code priority 1 (high)

Comments

@Alex-Jordan
Copy link
Contributor

We've hit a bug with a reduction rule in MathObjects. Something like -5/(-2x) is incorrectly reducing to 5/2*x. Here is a MWE.

DOCUMENT();

loadMacros(
  "PGstandard.pl",
  "MathObjects.pl",
  "PGML.pl",
);

TEXT(beginproblem());

$answer = Formula("-5/(-2 x)");
$reduced = $answer->reduce;

BEGIN_PGML

The answer is [$answer], which reduces to [$reduced].

END_PGML

ENDDOCUMENT();

(I'm having trouble logging in to the forum while the transition is underway, or else I might have posted this there.)

@drgrice1
Copy link
Member

You need to do a password reset on the wiki. After you do that you will be able to sign in to the wiki and the Moodle forums. Go to https://webwork.maa.org/wiki/Special:PasswordReset to do this.

@mgage
Copy link
Member

mgage commented Feb 27, 2020

Glenn,
Do you know if the emails for password reset are being sent out by the wiki?

@drgrice1
Copy link
Member

I am not sure. I was hoping so. I will look into it.

@drgrice1
Copy link
Member

It seems that the password reset emails are not being sent (or at least received).

@dlglin
Copy link
Member

dlglin commented Feb 27, 2020

When I request a password reset email it is sent and caught in our spam filter, likely because it came from apache@🌻.invalid (see openwebwork/webwork.maa.org#29).

@dpvc dpvc added the MathObject issue Issue involving MathObects code label Mar 1, 2021
@Alex-Jordan
Copy link
Contributor Author

This is still a bug (just tested on develop). The wiki login discussion may have distracted from the issue I reported.

@dpvc
Copy link
Member

dpvc commented Mar 14, 2021

I have made a PR (#546) that addresses this issue. Sorry for the long wait for it. It has scrolled off the top of my email screen, where I don;'t often look, and so was in limbo until I cleared out some more recent items.

Alex-Jordan added a commit that referenced this issue Mar 15, 2021
Use parens again if negative is factored out.  (#455)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MathObject issue Issue involving MathObects code priority 1 (high)
Projects
None yet
Development

No branches or pull requests

6 participants