Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Fix error in TextDescriptorReader when data contains leading empty spaces #691

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

mburshteyn1
Copy link
Contributor

@mburshteyn1 mburshteyn1 commented Aug 8, 2022

QR Code parsing is failing when QR code contains leading spaces.

Next function advances the pointer by 1 past mFieldEnd to skip the field separator. When empty spaces are present the initial Next call advances past the first empty space before performing the empty space check, ending up on the version value instead of the initial key. This change initializes mFieldEnd to match mReadPoint which is val with removed empty spaces.

@lcniles
Copy link
Contributor

lcniles commented Aug 8, 2022

lgtm

@robszewczyk robszewczyk merged commit e3c8ca3 into openweave:master Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants