Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

WEAV-3246: Dockerfile for weave device manager #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NLAVogel
Copy link

Also add init.py so when files are installed in dist-packages they
can be imported.

Also add __init__.py so when files are installed in dist-packages they
can be imported.
@codecov-io
Copy link

Codecov Report

Merging #249 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
- Coverage   54.22%   54.21%   -0.02%     
==========================================
  Files         332      332              
  Lines       56403    56403              
==========================================
- Hits        30586    30579       -7     
- Misses      25817    25824       +7
Impacted Files Coverage Δ
third_party/lwip/repo/lwip/src/core/pbuf.c 35.2% <0%> (-1.6%) ⬇️
src/lwip/standalone/sys_arch.c 69.01% <0%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0666493...6c81725. Read the comment docs.

Copy link
Contributor

@jaylogue jaylogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether the Weave Device Manager will work correctly in all cases when run inside a Docker instance. In particular, will the Weave rendezvous protocol, which requires IPv6 multicast, work correctly between a Docker instance and a real device?

RUN cd weave && \
./configure --disable-systemd && \
make all && \
make install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be using Makefile-Standalone whenever we build any of the desktop tools, rather than invoking ./configure with default args. The former employs project configuration files that configures OpenWeave specifically for desktop use.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants