Feature/vgrid vs arrays shape (This PR shall be merged first) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerGeRybakov
had a problem deploying
to
github-pages
GitHub Actions
Failure
SerGeRybakov
had a problem deploying
to
github-pages
GitHub Actions
Failure
SerGeRybakov
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
This PR shall be merged first |
SerGeRybakov
changed the title
matveyvarg
reviewed
Aug 7, 2023
deker/schemas.py
Outdated
Comment on lines
342
to
349
| splitters = { | ||
| attr: getattr(self, attr) for attr in ("vgrid", "arrays_shape") if getattr(self, attr) | ||
| } | ||
| if len(splitters) < 1: | ||
| raise DekerValidationError("Either `vgrid` or `arrays_shape` shall be passed") | ||
| if len(splitters) > 1: | ||
| raise DekerValidationError("Either `vgrid` or `arrays_shape` shall be passed, not both") | ||
| splitter, value = tuple(splitters.items())[0] |
There was a problem hiding this comment.
Same logic as in adapters ? Can't we have it in one place ?
…ved to deker.schemas
SerGeRybakov
had a problem deploying
to
github-pages
GitHub Actions
Failure
matveyvarg
approved these changes
Aug 7, 2023
iakovdudinsky
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VArray shape may be split either by
vgridor byarrays_shapeargument:vgridsplits VArray shape and creates the shape of all underlying Arraysarrays_shapesets the shape of all underlying Arrays and creates vgrid