-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename packages into @sd-jwt #77
Conversation
}, | ||
"dependencies": { | ||
"@hopae/sd-jwt-type": "2.0.3", | ||
"@hopae/sd-jwt-util": "2.0.3" | ||
"@sd-jwt/types": "workspace:*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cre8 This part has actual version. So I changed it to workspace:* again.
I think lerna publish set the version here. Was this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah workspace:*
should be swapped by lerna for the release. You can check the setup at https://github.com/berendsliedrecht/sd-jwt-ts as we used the exact same setup there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think when you run lerna version it will set it. Using * seems better for me.
Signed-off-by: Lukas <[email protected]>
Signed-off-by: Lukas <[email protected]>
Signed-off-by: Lukas <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Lukas <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Changes