-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project proposal to move DCQL to OWF #48
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @TimoGlastra, Wow your projects looks really great! |
@TimoGlastra : Will you be available on January 8, 2025 to represent this proposal? |
Yes, as long as it doesn't clash with the Wallet Interoperability SIG! |
This should be the week of the offset meeting due to the TAC call. The SIG call would follow immediately after. See you on January 8. Have a good holiday period. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not see any DCO on the commits. This will also need to be updated prior to bringing it over to OWF. Otherwise, this looks like an interesting lab, and I approve it.
Perfect, thanks. You too 🎅 |
I think it's for the suggestions i comitted. Once ready to merge based on feedback i'll squash everything |
This was related to the project repo, not this PR. Just to be sure we are on the same page. |
Something I'd like input on during the TAC WG or here: I've been chatting with @marsouin and @auer-martin a PEX light library that will be very similar in design as this DCQL library. Should we propose this as a separate lab project? Can it fall under this one and we make it "credential query languages typescript" project (but still two repositories)? |
Misunderstood you there, opened an issue: auer-martin/dcql#25 |
Signed-off-by: Timo Glastra <[email protected]>
A single lab can have multiple repositories. We typically use some sort of prefix to group the repos. Something like "CQL-repo1" and "CQL-repo2". We would just need to determine the correct prefix, which should be based on the name of the lab. |
I'll be looking at the dco and the other issues in the dcql repository over the weekend |
Still need to add a sponsor, and want to get a review from @auer-martin first.