Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/bc wallet with bc showcase automated tests #208

Merged

Conversation

nodlesh
Copy link
Contributor

@nodlesh nodlesh commented Nov 17, 2023

This PR adds a new suite of BC Wallet tests that use the BC Showcase demo as issuers and verifiers.

There is also a new run in the test pipeline for the showcase specific tests that will go to a separate Allure project for test results.

There still needs to be some work on the Lawyer scenario, however I wanted to get this in to see if there was any issue running these in the nightly regression.

Copy link

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a Python nor Selenium expert but read through it all and was able to follow the logic. Looks good to me. Out of curiosity, why do you use XPATH in some selectors and not others?

@nodlesh
Copy link
Contributor Author

nodlesh commented Nov 17, 2023

I try to use XPATH as less as possible. In the BC Wallet app they are not used, but when interfacing with a webpage like the BC Showcase, XPATH is usually the fasted and easiest way to get a unique identifier for a web element.

@nodlesh nodlesh merged commit e6f24b7 into openwallet-foundation:main Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants