Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(routing): support did:key in RFC0211 #950

Merged

Conversation

TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Jul 14, 2022

Does not send did:key dids yet, only supports processing did:key dids. Sending did:key dids
will be added in a future (breaking) PR and release.

Relevant issue in ACA-Py: openwallet-foundation/acapy#1859

Signed-off-by: Timo Glastra [email protected]

Does not send did:key dids yet, only supports processing did:key dids. Sending did:key dids
will be added in a future (breaking) PR and release.

Signed-off-by: Timo Glastra <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2022

Codecov Report

Merging #950 (ba8092d) into main (f48f3c1) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
+ Coverage   87.67%   87.76%   +0.09%     
==========================================
  Files         475      475              
  Lines       11414    11417       +3     
  Branches     1938     1938              
==========================================
+ Hits        10007    10020      +13     
+ Misses       1340     1332       -8     
+ Partials       67       65       -2     
Impacted Files Coverage Δ
...ules/routing/services/MediationRecipientService.ts 84.61% <100.00%> (+0.09%) ⬆️
...re/src/modules/routing/services/MediatorService.ts 92.55% <100.00%> (+4.50%) ⬆️
packages/core/src/modules/dids/helpers.ts 95.23% <0.00%> (+4.76%) ⬆️
.../src/modules/routing/repository/MediationRecord.ts 94.23% <0.00%> (+9.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f48f3c1...ba8092d. Read the comment docs.

@TimoGlastra TimoGlastra enabled auto-merge (squash) July 14, 2022 19:25
Copy link
Contributor

@JamesKEbert JamesKEbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nits

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra force-pushed the feat/did-key-mediation branch from 0121ae2 to 4b741f1 Compare July 15, 2022 08:51
@TimoGlastra TimoGlastra disabled auto-merge July 15, 2022 08:52
@TimoGlastra TimoGlastra merged commit dc45c01 into openwallet-foundation:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants