Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/indy namespace #945

Conversation

morrieinmaas
Copy link
Contributor

closes #944

Moriarty added 20 commits June 23, 2022 16:23
TODO: add tests for new functionality

Signed-off-by: Moriarty <[email protected]>
todo:
* move this logic to ledger module

Signed-off-by: Moriarty <[email protected]>
…chema-and-creds

todo:
* move findBy methods to ledgerModule and out of the anonCreds impls

Signed-off-by: Moriarty <[email protected]>
…chema-and-creds

code review feedback

Signed-off-by: Moriarty <[email protected]>
@morrieinmaas morrieinmaas changed the base branch from main to 0.3.0-pre July 12, 2022 14:17
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #945 (25445ae) into 0.3.0-pre (4800700) will increase coverage by 0.22%.
The diff coverage is 90.42%.

@@              Coverage Diff              @@
##           0.3.0-pre     #945      +/-   ##
=============================================
+ Coverage      87.73%   87.96%   +0.22%     
=============================================
  Files            475      479       +4     
  Lines          11349    11521     +172     
  Branches        1875     1910      +35     
=============================================
+ Hits            9957    10134     +177     
+ Misses          1325     1320       -5     
  Partials          67       67              
Impacted Files Coverage Δ
...e/src/modules/ledger/services/IndyLedgerService.ts 69.27% <ø> (+2.08%) ⬆️
.../repository/AnonCredsCredentialDefinitionRecord.ts 81.81% <81.81%> (ø)
...c/modules/indy/repository/AnonCredsSchemaRecord.ts 81.81% <81.81%> (ø)
...dules/indy/repository/AnonCredsSchemaRepository.ts 85.71% <85.71%> (ø)
...ository/AnonCredsCredentialDefinitionRepository.ts 94.44% <94.44%> (ø)
packages/core/src/modules/ledger/LedgerModule.ts 97.22% <94.44%> (+16.73%) ⬆️
packages/core/src/modules/ledger/ledgerUtil.ts 100.00% <100.00%> (ø)
packages/core/src/storage/Repository.ts 100.00% <0.00%> (ø)
packages/core/src/modules/oob/OutOfBandModule.ts 88.01% <0.00%> (+0.51%) ⬆️
packages/core/src/utils/messageType.ts 98.61% <0.00%> (+0.93%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4800700...25445ae. Read the comment docs.

@TimoGlastra
Copy link
Contributor

I think this can be closed in favour of #965 @morrieinmaas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants