-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/indy namespace #945
Closed
morrieinmaas
wants to merge
20
commits into
openwallet-foundation:0.3.0-pre
from
morrieinmaas:feat/indyNamespace
Closed
Feat/indy namespace #945
morrieinmaas
wants to merge
20
commits into
openwallet-foundation:0.3.0-pre
from
morrieinmaas:feat/indyNamespace
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
…er service still wip Signed-off-by: Moriarty <[email protected]>
TODO: add tests for new functionality Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
…ead of throwing an error Signed-off-by: Moriarty <[email protected]>
todo: * move this logic to ledger module Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
…chema-and-creds todo: * move findBy methods to ledgerModule and out of the anonCreds impls Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
…chema-and-creds Signed-off-by: Moriarty <[email protected]>
…chema-and-creds code review feedback Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
…hemas Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Signed-off-by: Moriarty <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 0.3.0-pre #945 +/- ##
=============================================
+ Coverage 87.73% 87.96% +0.22%
=============================================
Files 475 479 +4
Lines 11349 11521 +172
Branches 1875 1910 +35
=============================================
+ Hits 9957 10134 +177
+ Misses 1325 1320 -5
Partials 67 67
Continue to review full report at Codecov.
|
I think this can be closed in favour of #965 @morrieinmaas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #944