feat(ledger): smart schema and credential definition registration

[morrieinmaas]

Signed-off-by: Moriarty [email protected]

closes #859

[codecov-commenter]

Codecov Report

Merging #900 (f64b016) into 0.3.0-pre (310185b) will increase coverage by 0.12%.
The diff coverage is 89.01%.

@@              Coverage Diff              @@
##           0.3.0-pre     #900      +/-   ##
=============================================
+ Coverage      86.97%   87.09%   +0.12%     
=============================================
  Files            532      536       +4     
  Lines          12965    13050      +85     
  Branches        2229     2244      +15     
=============================================
+ Hits           11276    11366      +90     
+ Misses          1593     1588       -5     
  Partials          96       96              

Impacted Files	Coverage Δ
.../repository/AnonCredsCredentialDefinitionRecord.ts	81.81% <81.81%> (ø)
...c/modules/indy/repository/AnonCredsSchemaRecord.ts	81.81% <81.81%> (ø)
...ository/AnonCredsCredentialDefinitionRepository.ts	85.71% <85.71%> (ø)
...dules/indy/repository/AnonCredsSchemaRepository.ts	85.71% <85.71%> (ø)
packages/core/src/modules/ledger/LedgerModule.ts	97.26% <94.59%> (+16.30%)	⬆️
packages/core/src/modules/ledger/ledgerUtil.ts	100.00% <100.00%> (ø)
...e/src/modules/ledger/services/IndyLedgerService.ts	69.89% <0.00%> (+2.04%)	⬆️
packages/core/src/error/IndySdkError.ts	100.00% <0.00%> (+60.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 310185b...f64b016. Read the comment docs.

[morrieinmaas]

Still need to add tests for new functionality. Old stuff works

[morrieinmaas]

Note to self @morrieinmaas & @blu3beri & @TimoGlastra still need to add tests.

[morrieinmaas]

@TimoGlastra @blu3beri would be great to get som efeedback before I add the tests - thanks in advance

[TimoGlastra]

This is great @morrieinmaas! Left some nits but mostly around naming. Overall implementation looks good.

[TimoGlastra]

This looks good to me @morrieinmaas. I think integrating the get schema/cred def and adding methods to get all created schema/cred def records would be a nice addition, but something we can add in a future pr without breaking changes.

As discussed yesterday only thing we should add is storing the associated ledger in the record. I'll try to add some more details later today on possible approaches

I'm going to Request Changes, mostly to prevent it from accidently being merged, but current code is approved

[morrieinmaas]

@TimoGlastra Thanks for the feedback. Should be addressed.

[TimoGlastra]

• add indyNamespace to the indy ledgers configuration (need to document this: https://hyperledger.github.io/indy-did-method/#indy-did-method-identifiers)
• add fully qualified identifier to the anon creds (schema|credential definition) records (replace the non qualified identifier before storing and after retrieving it). For indy we use the did:indy spec identifiers to store.
  • Note: Records stores fully qualified identifier as identifier.
  • Need to transform unqualified to qualified before storing or querying
  • Need to transform qualified to unqualified after retrieving
• Need to return the fully qualified id somehow from the service (either by adding qualifiedId return value, or overriding the id before returning and the setting it as the unqualified again after storing it).
• Ledger module construct fully qualified string/name. Check with that against record store

[morrieinmaas]

@TimoGlastra - changes addressed

[morrieinmaas]

@TimoGlastra can this be merged then?