Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(credentials): indy cred attachment format #862

Merged
merged 3 commits into from
Jun 15, 2022
Merged

fix(credentials): indy cred attachment format #862

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c6bb54
fix(credentials): indy cred attachment format
TimoGlastra Jun 15, 2022
cfc1e8f
Merge branch 'main' into fix/cred-format-attachment
TimoGlastra Jun 15, 2022
fc67975
Merge branch 'main' into fix/cred-format-attachment
TimoGlastra Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/core/src/modules/credentials/formats/indy/IndyCredentialFormatService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ import { IndyCredPropose } from './models/IndyCredPropose'
const INDY_CRED_ABSTRACT = 'hlindy/[email protected]'
const INDY_CRED_REQUEST = 'hlindy/[email protected]'
const INDY_CRED_FILTER = 'hlindy/[email protected]'
const INDY_CRED = 'hlindy/[email protected]'

@scoped(Lifecycle.ContainerScoped)
export class IndyCredentialFormatService extends CredentialFormatService<IndyCredentialFormat> {
Expand Down Expand Up @@ -302,7 +303,7 @@ export class IndyCredentialFormatService extends CredentialFormatService<IndyCre

const format = new CredentialFormatSpec({
attachId,
format: INDY_CRED_ABSTRACT,
format: INDY_CRED,
})

const attachment = this.getFormatData(credential, format.attachId)
Expand Down Expand Up @@ -355,7 +356,7 @@ export class IndyCredentialFormatService extends CredentialFormatService<IndyCre
}

public supportsFormat(format: string): boolean {
const supportedFormats = [INDY_CRED_ABSTRACT, INDY_CRED_REQUEST, INDY_CRED_FILTER]
const supportedFormats = [INDY_CRED_ABSTRACT, INDY_CRED_REQUEST, INDY_CRED_FILTER, INDY_CRED]

return supportedFormats.includes(format)
}
Expand Down