Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proofs): allow duplicates in proof attributes #848

Conversation

Iskander508
Copy link
Contributor

@Iskander508 Iskander508 commented Jun 10, 2022

This is a partial fix for #837
The check is limited to duplicates between predicates and attributes only. Duplicit attributes should be allowed as they don't cause any error during proof creation.
Still todo: Either

  • parse and validate based on restrictions, whether the items collide or not
    or
  • completely rethink the check and validate only at the point of ProofsModule.acceptRequest (which is the actual problem)

@Iskander508 Iskander508 requested a review from a team as a code owner June 10, 2022 13:58
@Iskander508 Iskander508 force-pushed the fix/duplicate_proof_attributes branch from 0a988f4 to db2b019 Compare June 10, 2022 14:07
@TimoGlastra TimoGlastra changed the title fix(proof): allow duplicates in proof attributes fix(proofs): allow duplicates in proof attributes Jun 14, 2022
Signed-off-by: Pavel Zarecky <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2022

Codecov Report

Merging #848 (2714a64) into main (8055652) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   87.60%   87.59%   -0.01%     
==========================================
  Files         459      458       -1     
  Lines       11179    11176       -3     
  Branches     1897     1897              
==========================================
- Hits         9793     9790       -3     
  Misses       1324     1324              
  Partials       62       62              
Impacted Files Coverage Δ
packages/core/src/utils/indyProofRequest.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8055652...2714a64. Read the comment docs.

@TimoGlastra TimoGlastra merged commit ca6c1ce into openwallet-foundation:main Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants